Skip to content

Oicd depreciated dependency switch to current #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

DevTKSS
Copy link

@DevTKSS DevTKSS commented Apr 20, 2025

GitHub Issue (If applicable): closes #

maybe related to #2716 #2686 #2640 #2584 (same old package mentioned by @kazo0 )

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes
  • Other... Please describe: Dependency update

What is the current behavior?

Currently used Package IdentityModel.OidcClient was rebranded, "old" github repo archived:
https://github.com/DuendeArchive/IdentityModel.OidcClient?tab=readme-ov-file

What is the new behavior?

https://www.nuget.org/packages/Duende.IdentityModel.OidcClient
Updated Dependency

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs

    Unable to run tests, vs 2022 throws error CS0227 (unsafe code ?) and CS0006 (metadata dll not found of the included extensions projects)

  • Docs have been added/updated which fit documentation template. (for bug fixes / features)

  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)

  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.

  • Contains NO breaking changes

  • Updated the Release Notes

  • Associated with an issue (GitHub or internal)

Other information

Evaluate to also use the Extensions nuget mentioned in their new Repository for Oidc, could enhance developers expirience by prevent problems https://www.nuget.org/packages/Duende.IdentityModel.OidcClient.Extensions#readme-body-tab
Copyed text:

Duende.IdentityModel.OidcClient.Extensions adds features to Duende.IdentityModel.OidcClient that are implemented using more dependencies than are required in the core Duende.IdentityModel.OidcClient package. Distributing these features separately helps prevent certain transitive dependency problems.

Internal Issue (If applicable):

@DevTKSS
Copy link
Author

DevTKSS commented Apr 22, 2025

@jeromelaban I seen your draft to the net10 and sometimes updated packages beside the net version.
Did you recognize the author of the IdentityModel.OidcClient the main uno repo (SamplesApp for example) is using, has been rebranded? I am not soo deep into nuget topic so just a point to consider on the way 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant