Allow creation of object-types with an empty relations block (#318)

kkajla12 · web-flow · commit 0b7eb1bda3e1 · 2024-04-01T20:10:38.000-07:00
diff --git a/pkg/authz/objecttype/spec.go b/pkg/authz/objecttype/spec.go
@@ -44,7 +44,7 @@ type ObjectTypeSpec struct {
 type CreateObjectTypeSpec struct {
 	Type      string                  `json:"type"             validate:"required,valid_object_type"`
 	Source    *Source                 `json:"source,omitempty"`
-	Relations map[string]RelationRule `json:"relations"        validate:"required,min=1,dive"` // NOTE: map key = name of relation
+	Relations map[string]RelationRule `json:"relations"        validate:"required,dive"` // NOTE: map key = name of relation
 }
 
 func (spec CreateObjectTypeSpec) ToObjectType() (*ObjectType, error) {
diff --git a/tests/v1/object-types-crud.json b/tests/v1/object-types-crud.json
@@ -4,7 +4,7 @@
     ],
     "tests": [
         {
-            "name": "failToCreateObjectWithoutRelations",
+            "name": "failToCreateObjectTypeWithoutRelations",
             "request": {
                 "method": "POST",
                 "url": "/v1/object-types",
@@ -21,6 +21,34 @@
                 }
             }
         },
+        {
+            "name": "createObjectTypeWithEmptyRelations",
+            "request": {
+                "method": "POST",
+                "url": "/v1/object-types",
+                "body": {
+                    "type": "A",
+                    "relations": {}
+                }
+            },
+            "expectedResponse": {
+                "statusCode": 200,
+                "body": {
+                    "type": "A",
+                    "relations": {}
+                }
+            }
+        },
+        {
+            "name": "deleteObjectTypeWithEmptyRelations",
+            "request": {
+                "method": "DELETE",
+                "url": "/v1/object-types/A"
+            },
+            "expectedResponse": {
+                "statusCode": 200
+            }
+        },
         {
             "name": "createObjectTypeReport",
             "request": {
@@ -342,4 +370,4 @@
             }
         }
     ]
-}
+}
diff --git a/tests/v2/object-types-crud.json b/tests/v2/object-types-crud.json
@@ -4,7 +4,7 @@
     ],
     "tests": [
         {
-            "name": "failToCreateObjectWithoutRelations",
+            "name": "failToCreateObjectTypeWithoutRelations",
             "request": {
                 "method": "POST",
                 "url": "/v2/object-types",
@@ -21,6 +21,34 @@
                 }
             }
         },
+        {
+            "name": "createObjectTypeWithEmptyRelations",
+            "request": {
+                "method": "POST",
+                "url": "/v2/object-types",
+                "body": {
+                    "type": "A",
+                    "relations": {}
+                }
+            },
+            "expectedResponse": {
+                "statusCode": 200,
+                "body": {
+                    "type": "A",
+                    "relations": {}
+                }
+            }
+        },
+        {
+            "name": "deleteObjectTypeWithEmptyRelations",
+            "request": {
+                "method": "DELETE",
+                "url": "/v2/object-types/A"
+            },
+            "expectedResponse": {
+                "statusCode": 200
+            }
+        },
         {
             "name": "createObjectTypeReport",
             "request": {

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ type ObjectTypeSpec struct {`
`44`	`44`	`type CreateObjectTypeSpec struct {`
`45`	`45`	Type string `json:"type" validate:"required,valid_object_type"`
`46`	`46`	Source *Source `json:"source,omitempty"`
`47`		- Relations map[string]RelationRule `json:"relations" validate:"required,min=1,dive"` // NOTE: map key = name of relation
	`47`	+ Relations map[string]RelationRule `json:"relations" validate:"required,dive"` // NOTE: map key = name of relation
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`func (spec CreateObjectTypeSpec) ToObjectType() (*ObjectType, error) {`