Swap Request/Response -> AWSPreparedRequest/AioAWSResponse types in endpoint.pyi #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! Yes, this is correct repo, Looks good, I am going to merge it today. Probably, I need to also re-release |
|
Thank you for merging so quickly! |
|
Your changes had been included to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the annotations of the
convert_to_response_dictto the "reality" of the underlying code:convert_to_response_dictfunction receivesAioAWSResponseobjects:AioEndpoint._send: https://github.com/aio-libs/aiobotocore/blob/7c41f8ad0cf70bf8a64b5196037f7445f43568e6/aiobotocore/endpoint.py#L181-L192self.http_session.send(...): https://github.com/aio-libs/aiobotocore/blob/7c41f8ad0cf70bf8a64b5196037f7445f43568e6/aiobotocore/endpoint.py#L293-L294http_sessionis, by default, aAIOHTTPSession: https://github.com/aio-libs/aiobotocore/blob/7c41f8ad0cf70bf8a64b5196037f7445f43568e6/aiobotocore/endpoint.py#L22AIOHTTPSession.sendreturns aAioAWSResponse: https://github.com/aio-libs/aiobotocore/blob/7c41f8ad0cf70bf8a64b5196037f7445f43568e6/aiobotocore/httpsession.py#L232-L242create_requestfunction returnsAWSPreparedRequest:create_requestreturns the result ofself.prepare_request: https://github.com/aio-libs/aiobotocore/blob/7c41f8ad0cf70bf8a64b5196037f7445f43568e6/aiobotocore/endpoint.py#L89-L90botocore.Endpoint.prepare_requestfrom the superclass, which returnsrequest.prepare(): https://github.com/boto/botocore/blob/51f1d36c1809357eb6322fdc699d00efe74c0218/botocore/endpoint.py#L148AWSRequest.prepareis documented to returnAWSPreparedRequest: https://github.com/boto/botocore/blob/51f1d36c1809357eb6322fdc699d00efe74c0218/botocore/awsrequest.py#L480Thanks for maintaining these stubs! I'm not sure if this PR should be here or against https://github.com/youtype/mypy_boto3_builder!