Skip to content

Inventory styles and ensure they are appropriately used & named #544

Open
@neiljp

Description

@neiljp

I'm pretty sure that we currently re-use some style names for elements which are un-related (eg. unread counts). This is mostly harmless, though confusing to read in the code, and now that we use more styles it would be useful to have a clearer idea of which are used and for what purposes.

The end result might involve having descriptive comments next to each entry in required_styles (if the names are insufficiently clear, in particular), and possibly changing the names of some styles, perhaps with prefixes.

Looking through the UI code will help find these instances, so this would be good to learn the way the UI works. To ensure that these cases are found, we may be able to use tests, but this may require manual checks - though automating this and having a tool for future use would be beneficial.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions