-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Replace flickr with pexels #29577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Replace flickr with pexels #29577
Conversation
The old project_flickr_api.md will be moved to archive/ruby_on_rails/ folder Replace project flickr api with project pexel api Move the old lesson file to archive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces instructions for using the Flickr API with updated guidance for using the Pexels API in The Odin Project curriculum. Key changes include:
- Adding a new file (project_pexels_api.md) with assignment details for a Pexels-based Rails photo widget.
- Removing the outdated Flickr API instructions.
- Archiving the previous Flickr API lesson into a separate archive folder.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
ruby_on_rails/apis/project_pexels_api.md | Newly added instructions guide developers to use the Pexels API instead of Flickr. |
ruby_on_rails/apis/project_flickr_api.md | Removed the old Flickr API instructions. |
archive/ruby_on_rails/project_flickr_api.md | Archived the previous Flickr API lesson for historical reference. |
I just reached the flicker API lesson, got stuck, then went through the Pexel lesson you are proposing. Seemed to go pretty smooth (pictured below). Some small feedback : There was some friction trying to upload some random photos. They want a certain quality (and megapixel) and my photos were being rejected. I found an easy workaround is that instead of uploading photos, you can browse the front page and add some photos quickly to your collection by hovering your mouse over the photo and pressing the collect icon in the top right. A potential reword could be something like: Ty @NikEmman for making this. Hope it gets reviewed soon 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking this project on @NikEmman
It'll take me a bit to properly review this as I'd like to try the project for myself and see how it feels to work through it.
In the meantime, you can go ahead and fix the mdlint issues that are being flagged. If you don't know where to find them, click the "Files changed" tab at the top of the PR and scroll down and you'll see where our linter has pointed out a few things.
You can also learn how to run the linting tool locally by checking in the curriculum linting section of the contributing guide
@JoshDevHub Fixed the md lint issues. Thanks for your detailed answer, made it easy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is all really good. Just finished trying the project for myself, and it went really well.
Just have one adjustment I'm going to recommend to have Flickr completely yanked out of the curriculum, and I also think it's a good idea to implement the suggestion above from @quarrybreeze
Let me know if you have any questions.
@@ -0,0 +1,24 @@ | |||
### Introduction | |||
|
|||
Remember the warm-up in the previous project when you played with the Flickr API? Now it's time for you to actually use it. Huzzah! For that however, instead of Flickr, we will use another service, called Pexels. You'll create a basic photo widget that allows you to display photos from your Pexels gallery. We'll rely on a tutorial for much of the heavy lifting but the principles of what you do here will be repeatable for use with other APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This warmup stuff using the Flickr API no longer makes sense to pursue. The previous lesson uses it as part 1 of the assignment, and again, users are going to be locked out of some of this functionality.
I kind of think we can just get rid of that warmup in the kittens project altogether, and then this opening paragraph would need adjusting to omit the references to it.
Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the late reply. Away from home atm, will work on it upon return in 4 days or so. Your recommendations sound right, will provide the refactored version here, and if changes are accepted will also update the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshDevHub On the subject of the reference to the previous lesson could be rephrased to something more generic, that can refer to the previous lesson regardless if it uses Flickr or is later refactored to something else. Maybe something along these lines
Currently in the PR:
-Remember the warm-up in the previous project when you played with the Flickr API? Now it's time for you to actually use it. Huzzah! For that however, instead of Flickr, we will use another service, called Pexels. You'll create a basic photo widget that allows you to display photos from your Pexels gallery. We'll rely on a tutorial for much of the heavy lifting but the principles of what you do here will be repeatable for use with other APIs.
After the review:
+Remember the warm-up in the previous project when you played with an API? Now it's time to actually use one. Huzzah! For that, we will use another service, called Pexels. You'll create a basic photo widget that allows you to display photos from your Pexels gallery. We'll rely on a tutorial for much of the heavy lifting but the principles of what you do here will be repeatable for use with other APIs.
On @quarrybreeze 's suggestion we use it as he wrote it. (Thanks by the way!)
Currently in the PR:
-4. Upload a few photos to your account! Then add them to a collection. Select the created collection, the URL will look like ` https://www.pexels.com/collections/collectionTitle-collectionIDhere/`. An example would be `adkmjqz`. You'll need that later for some of the API methods.
After the review:
+ 4. Browse the website for some photos then add them to a collection (or upload your own!). Navigate to your created collection, and notice the URL will look like ` https://www.pexels.com/collections/collectionTitle-collectionIDhere/`. An example would be `adkmjqz`. You'll need that later for some of the API methods.
As a final note, I'm also offering myself to re-write the previous lesson. Should I create an issue?
Please let me know your thoughts. Thanks for your time!
…iculum into replace_flickr_with_pexels
Because
Many users have reported encountering issues with the Flickr API project within TheOdinProject curriculum. Specifically, problems include difficulties with signing in, logging in, and frequent "Account creation failed" errors.
This PR
Issue
Closes #28285
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section