Remove ReadyToRun prefix from image layout code #115188
Open
+68
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now shared with native AOT.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the image layout code by removing the "ReadyToRun" prefix from various types and method names to share the implementation with native AOT.
- Renamed enums and options from ReadyToRunMethodLayoutAlgorithm/ReadyToRunFileLayoutAlgorithm to MethodLayoutAlgorithm/FileLayoutAlgorithm.
- Updated function names and associated variables accordingly across multiple projects.
- Adjusted string formatting and error handling to reference the new enum types.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/tools/aot/crossgen2/Crossgen2RootCommand.cs | Updated layout option types and corresponding helper methods. |
| src/coreclr/tools/aot/ILCompiler/ILCompilerRootCommand.cs | Changed layout option types and helper methods to use new enum names. |
| src/coreclr/tools/aot/ILCompiler.RyuJit/Compiler/RyuJitCompilationBuilder.cs | Adjusted variable types and method signatures for file layout algorithms. |
| src/coreclr/tools/aot/ILCompiler.RyuJit/Compiler/RyuJitCompilation.cs | Updated constructor parameter types and optimizer instantiation. |
| src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunCodegenCompilationBuilder.cs | Modified API to accept new layout algorithm types. |
| src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunCodegenCompilation.cs | Switched to new file layout optimizer and updated parameters. |
| src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/FileLayoutOptimizer.cs | Renamed enums and class, and updated switch cases to use the new names. |
Files not reviewed (2)
- src/coreclr/tools/aot/ILCompiler.ReadyToRun/ILCompiler.ReadyToRun.csproj: Language not supported
- src/coreclr/tools/aot/ILCompiler.RyuJit/ILCompiler.RyuJit.csproj: Language not supported
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now shared with native AOT.
Cc @dotnet/ilc-contrib