Skip to content

Fix: Tried to fix the fid mis match under some cases #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

Woody-Hu
Copy link
Contributor

What problem does this PR solve?

#7407

Based on this context, I think there should be some reasons that let some LLMs have a mismatch (add the wrong "@xxx"),
So I think when use fid can not fetch llm then tried to just use name should can fetch it.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 30, 2025
@dosubot dosubot bot added the 🐞 bug Something isn't working, pull request that fix bug. label Apr 30, 2025
@Woody-Hu
Copy link
Contributor Author

Woody-Hu commented Apr 30, 2025

Hi @Robert0611 I base on my experience and the ticket context tried to fix your problem, do you have an env to verify this PR? Thanks

@Robert0611
Copy link

Hi@Woody-Hu Thanks for your attention. I attach my env (change to be txt for uploading) here for your kind checking and so appreciate!
env.txt

@KevinHuSh KevinHuSh added the ci Continue Integration label Apr 30, 2025
@KevinHuSh KevinHuSh merged commit 2dbcc0a into infiniflow:main Apr 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working, pull request that fix bug. ci Continue Integration size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants