-
-
Notifications
You must be signed in to change notification settings - Fork 340
Improve/Fix zh-TW i18n locale #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks @PeterDaveHello for taking the time to proofread the translation. That will be a great improvement over the automated one 👏 @hugolpz Would you mind doing a review of @PeterDaveHello MR? I will have a go with Perapera but in my memory tech-related terms are often poorly covered by dictionaries |
a941887
to
3cf12f1
Compare
Any chance we can move forward? |
Hello @PeterDaveHello , my appologizes, I though I already reviewed this PR long time ago or maybe I mix up with another of yours ? Anyway. While not a native Chinese speaker myself I understand those changes are stylistic, and I suspect, regional changes. While both written in traditional Chinese characters, I indeed recognized some Taiwanese expressions which sounded more familiar than the former expressions. So I encourage @edouard-lopez to accept the PR. @PeterDaveHello , again, my apologizes for the delay. And thank you ! Happy to get Taiwanese Guoyu on Lesspass. ❤️ 🇹🇼 |
Hello @PeterDaveHello, thank you and sorry for having been so long. I rewrote completly LessPass and changed all the translations. Can you give a look at https://github.com/lesspass/lesspass/blob/main/packages/lesspass-web-component/public/locales/zh-TW/translation.json ? Sorry it has been generated by chatGPT Closing this one |
@guillaumevincent, if you can reopen this one, I can try. With respect, can anyone help confirm that we won't waste time updating the translation and end up dropping it again? |
yes sure, I'm sorry. It was easier/faster for me to redo all the translations than adpating them after the complete rewrite of all components. |
392e293
to
1073505
Compare
Obviously many of the translations were simply converted from Simplified Chinese without proper translation 😅