Hi @mihaelaaleks , do you have a status update?

@DonWillems Apologies for the overdue update 😅 I have some last tests to add and I'll push my changes for review by tomorrow.

Hi Michaela, it took a while for me to find the time, but here are some points that stood out to me:

Bugs / Incorrect Behavior

• As you mentioned the deliveredOn and acknowledgedOn timestamps aren't set correctly by the apps. I created a separate bug for this: Console: Notification status is not updated to delivered or acknowledged by the iOS and Android apps #1819. If I use the endpoints manually, the table does update the status correctly.
• When creating a notification but not filling in all required fields (like title and content) you can press the create button, but you will get an error. The Create button should only be enabled if you filled in all the required fields.
• When creating a notification with an asset as target that does not have a linked user, the notification correctly can't be sent. However, the notification says: "Failed to create notification:" with no explanation.
• realm field stays invalid even if a realm is set:
  
• Every time I tab back to the table page, it's recollecting all the rows?
• Something weird is going on with sorting on sent date time:
  

UX/UI Improvements

• Asset tree is awkward in the dialog, as it doesn't fit with many assets (and otherwise looks off too).
  I understand why you chose this over opening it as a dialog. I think we should do it like it is in rules: first select asset type, then a (multi)select of the assets of that type. With at the top of that list the option to select 'All of this type'.
  
• Target is clickable, underline the target so that it is clear that it is individually clickable as opposed to the click anywhere else on the row.
• When a filter does not return any results it should state so in a message in the table.

Functionality Enhancements

• Service users shouldn't be shown in the users list
• You can't multiselect users, which will make sending notifications tedious. Add functionality to add multiple users.
• Ideally you would also want to be able to select all users that have a certain realm role or role.
• If a notification is sent to user, it still shows as target: asset. I assume there is no way to read this from the notification in the db. I think we should always show the linked user(s) of the target asset to give the needed information.
  The downside is that if the linked user is changed, the info won't be correct historically. But let's accept that for now.
• The rule id that sent the notification is not available? Should we add that?
• What does priority do when creating a notification?

Performance

• Why are you doing a call per row? Is it to get the name and icon of the target asset? Find out if there is a better way, if there isn't, maybe we need to leave the name out?
• Remove the console messages

Nice to Haves

• Add a search that matches anything in the 'title', asset id, and 'linked user'. Filter out the rows that match
• Is there a way to combine notifications that are sent from one rule trigger/from one manual action? If it is sent to 100 consoles at once, you will have 100 entries. Would be nice to have that as 1 entry; or an entry per status.

Turned out to be quite a list. If there is anything unclear, feel free to give me a call. Also, if you need some help from the developers don't hesitate to contact them.