Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck markup on travis #853
Conversation
I need to work on this, the |
It's working now but the build take 20 minutes |
Taking 20 minutes each build is a little hard. IMO |
Maybe check only modified pages or only |
Faster and this are the most changed files
@makimoto It's about 5 minutes now and it check all current year news, which are the most patched/added. |
Still need to consider whether it's worth the extra time for each build. And if we include this check, what about the others? Shouldn't we include them also...? |
@stomar |
After thinking it over again: I'm against including this test in every build. The tests should be run manually for gem updates, layout changes, and the like. The current system with markdown and html templates avoids most of the markup errors. Note that the vast majority of the recent markup fixes (#832) stem from "legacy" content transfered from the previous RadiantCMS site. |
You are right about "legacy" markup fixes, feel free to close this PR. |
spk commentedSep 23, 2014
Hello,
It's a continuation of #844 and #832, to keep the website valid and have notification from travis on markup errors.