Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set property 'isRootInsert' of undefined #4589

Closed
johnleider opened this issue Dec 27, 2016 · 4 comments
Closed

Cannot set property 'isRootInsert' of undefined #4589

johnleider opened this issue Dec 27, 2016 · 4 comments

Comments

@johnleider
Copy link
Contributor

@johnleider johnleider commented Dec 27, 2016

Vue.js version

2.1.7

Reproduction Link

repo https://github.com/vuetifyjs/docs.git#2.1.7-update

Steps to reproduce

Install deps, run dev, navigate to any view that uses a top level component with a default slot, layouts for example.

What is Expected?

The view to load

What is actually happening?

Error Cannot set property 'isRootInsert' of undefined

Additional

I've been following #4584 and pulled down the updated patch and tested it with no difference in results.

@sqal
Copy link
Contributor

@sqal sqal commented Dec 27, 2016

It really looks like it's the same issue as #4584 Everything is fine with your code to this point:

DocView.vue

<template lang="pug">
  div.view
    section
      section-def
        dt(slot="title" v-html="doc.title")
        dd(slot="desc" v-html="doc.desc")
    section
      section-header Examples

but when you add <slot> after that, it breaks with isRootInsert error.

@johnleider
Copy link
Contributor Author

@johnleider johnleider commented Dec 27, 2016

Correct. It also only breaks because the slotted components have default slots of their own. Notice the named slot which contains a component with no slot, it works just fine.

@yyx990803
Copy link
Member

@yyx990803 yyx990803 commented Dec 28, 2016

Since the patch was in the codegen, you will need to use updated vue-template-compiler as well. I cloned your repo and tested locally using everything from my local branch and it seems to be working correctly (all the views render properly), so I think it is indeed caused by the same bug.

If you want to test it yourself, you can clone the Vue repo, build everything and link vue and vue-template-compiler and vue-server-renderer into your project.

(great job on vuetify, btw!)

@johnleider
Copy link
Contributor Author

@johnleider johnleider commented Dec 28, 2016

Thanks Evan, didn't think about those packages as well. Appreciate all the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants