bpo-30184: Add tests for invalid use of PyArg_ParseTupleAndKeywords. #1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @tim-one and @larryhastings to be potential reviewers. |
louisom
suggested changes
Apr 28, 2017
| self.assertRaises(SystemError, _testcapi.parse_tuple_and_keywords, | ||
| (), {}, '|$O', ['']) | ||
| self.assertRaises(SystemError, _testcapi.parse_tuple_and_keywords, | ||
| (), {}, '|OO', ['a', '']) |
There was a problem hiding this comment.
May add test case for misuse of ; and :
self.assertRaises(SystemError, _testcapi.parse_tuple_and_keywords,
(1,), {}, ':O', ['a'])
self.assertRaises(SystemError, _testcapi.parse_tuple_and_keywords,
(1,), {}, ';O', ['a'])There was a problem hiding this comment.
These tests don't trigger any error that is not tested.
|
|
||
| def test_bad_use(self): | ||
| # Test handling invalid format and keywords in | ||
| # PyArg_ParseTupleAndKeywords() |
There was a problem hiding this comment.
Can this use the method below parser = _testcapi.parse_tuple_and_keywords to reduce the length?
There was a problem hiding this comment.
This doesn't matter, in any case the line is wrapped.
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 3, 2017
…ords. (pythonGH-1316). (cherry picked from commit 5f161fd)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 3, 2017
…ords. (pythonGH-1316). (cherry picked from commit 5f161fd)
serhiy-storchaka
added a commit
that referenced
this pull request
May 4, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.