Skip to content

[3.6] bpo-29974: Improve typing.TYPE_CHECKING example (GH-982) #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2017
Merged

[3.6] bpo-29974: Improve typing.TYPE_CHECKING example (GH-982) #1297

merged 1 commit into from
Apr 26, 2017

Conversation

berkerpeksag
Copy link
Member

  • Fix PEP 8 (SomeType instead of some_type)
  • Add a function parameter annotation
  • Explain, using wording from PEP 484 and PEP 526,
    why one annotation is in quotes and another is not.

Suggested by Ivan Levkevskyi.

(cherry picked from commit 87c07fe)

@Mortal @berkerpeksag
bpo-29974: Improve typing.TYPE_CHECKING example (pythonGH-982)
cef7b1e 
* Fix PEP 8 (SomeType instead of some_type)
* Add a function parameter annotation
* Explain, using wording from PEP 484 and PEP 526,
  why one annotation is in quotes and another is not.

Suggested by Ivan Levkevskyi.

(cherry picked from commit 87c07fe)
@berkerpeksag berkerpeksag merged commit 04f389b into python:3.6 Apr 26, 2017
@berkerpeksag berkerpeksag deleted the 29974-backport-3.6 branch April 26, 2017 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@berkerpeksag @ilevkivskyi @the-knights-who-say-ni @Mortal