Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong order of generate modifier code #5147

Merged
merged 3 commits into from Mar 10, 2017
Merged

Conversation

Kingwl
Copy link
Member

@Kingwl Kingwl commented Mar 9, 2017

#5146

@posva
review need

@posva
Copy link
Member

posva commented Mar 9, 2017

Hey, thanks. Can you add a test for stop too?

@Kingwl
Copy link
Member Author

Kingwl commented Mar 9, 2017

@posva sure

posva
posva approved these changes Mar 9, 2017
Copy link
Member

@posva posva left a comment

I think the codegen test is enough, but 👍

@yyx990803 yyx990803 merged commit 4964b25 into vuejs:dev Mar 10, 2017
@Kingwl Kingwl deleted the fix-prevent branch Mar 10, 2017
awamwang added a commit to awamwang/vue that referenced this pull request Mar 16, 2017
* 'dev' of https://github.com/vuejs/vue: (118 commits)
  [weex] Support unary and left open tags (vuejs#5052)
  [release] 2.2.4
  [build] 2.2.4
  fix perf measure regression for nested components of the same name (fix vuejs#5181)
  [release] 2.2.3
  [build] 2.2.3
  perf code coverage
  improve camelCase prop warning message
  warn when template contains text outside root element (vuejs#5164)
  Warn when not passing props in kebab-case (vuejs#5161)
  turn off perf timeline measuring by default + reduce its impact on dev time perf (fix vuejs#5174)
  v-bind object should have lower priority than explicit bindings (fix vuejs#5150)
  fix custom directive arg fall through (fix vuejs#5162)
  formatting tweaks
  refactor create-component
  fix wrong order of generate modifier code (vuejs#5147)
  fix v-on unit test (vuejs#5144)
  fix vuejs#5121: parse content in textarea as plaintext (vuejs#5143)
  [release] 2.2.2
  [build] 2.2.2
  ...

# Conflicts:
#	dist/vue.runtime.common.js
#	src/core/vdom/helpers/update-listeners.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants