Fix filters parsing incorrectly because of missing spaces (fix #4881) #4923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue is absent in 1.1 and 2.0 branches because of a different approach to parsing. It would still be great to add tests for this case. I've added the test for 1.1 in my fork, will make a PR if everything will be good with this one. |
|
guys? |
|
Saw this come through my inbox via CodeTriage. So, in the spirit of trying to be helpful, should this be merged? Is the fix already implemented in existing release? Hoping this helps to resolve a PR that's been stale for a while. |
|
ah yeah, this PR is for v1 which is not receiving any updates anymore. We can close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing parseFilter returning only the first filter of a chain in case of expression missing spaces.
See #4881