/scikit-learn

[MRG] MAINT Changed deprecated plt.cm.spectral to plt.cm.nipy_spectral #10764

Merged
merged 1 commit into from Mar 7, 2018
+11 −11

Conversation

Reviewers

@jnothman jnothman

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@qinhanmin2014 @jnothman
@qinhanmin2014
Member

qinhanmin2014 commented Mar 7, 2018

FIxes #10761
I think it's a blocker so I try to take it
Check the result from Circle to see whether we need if...else... here
@qinhanmin2014
deprecate spectral

All checks have passed

8 successful checks
ci/circleci: deploy — Your tests passed on CircleCI!
Details
ci/circleci: python2 — Your tests passed on CircleCI!
Details
ci/circleci: python3 — Your tests passed on CircleCI!
Details
@codecov
codecov/patch — Coverage not affected when comparing 61e6f50...c0adb22
Details
@codecov
codecov/project — 95.01% remains the same compared to 61e6f50
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
lgtm analysis: Python — No alert changes
Details
c0adb22

@qinhanmin2014 qinhanmin2014 changed the title from MAINT Changed deprecated plt.cm.spectral to plt.cm.nipy_spectral to [MRG] MAINT Changed deprecated plt.cm.spectral to plt.cm.nipy_spectral Mar 7, 2018

@qinhanmin2014

This comment has been minimized.

Show comment Hide comment
@qinhanmin2014

qinhanmin2014 Mar 7, 2018

Member

I've checked Circle. (The result from python2 is slightly different but I think it's because we use different matplotlib version)

Member

qinhanmin2014 commented Mar 7, 2018

I've checked Circle. (The result from python2 is slightly different but I think it's because we use different matplotlib version)

@qinhanmin2014 qinhanmin2014 requested a review from jnothman Mar 7, 2018

@qinhanmin2014 qinhanmin2014 added the Blocker label Mar 7, 2018

@jnothman

This comment has been minimized.

Show comment Hide comment
@jnothman

jnothman Mar 7, 2018

Owner

LGTM. I've checked rendering and that this list is complete.

Owner

jnothman commented Mar 7, 2018

LGTM. I've checked rendering and that this list is complete.

@jnothman jnothman merged commit 6f73949 into scikit-learn:master Mar 7, 2018
8 checks passed

8 checks passed

ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: python2 Your tests passed on CircleCI!
Details
ci/circleci: python3 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 61e6f50...c0adb22
Details
codecov/project 95.01% remains the same compared to 61e6f50
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@qinhanmin2014 qinhanmin2014 deleted the qinhanmin2014:deprecate-spectral branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment