Skip to content

[MRG] Removes Imputer References from docs #10750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thechargedneutron
Copy link
Contributor

Reference Issues/PRs

Fixes #10689

What does this implement/fix? Explain your changes.

Any other comments?

Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thechargedneutron for the PR :)

@@ -589,60 +589,6 @@ columns for this feature will be all zeros
See :ref:`dict_feature_extraction` for categorical features that are represented
as a dict, not as scalars.

.. _imputation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this and leave a note pointing to the new document, otherwise some links will be broken.
E.g., https://19893-843222-gh.circle-artifacts.com/0/doc/modules/generated/sklearn.preprocessing.Imputer.html#sklearn.preprocessing.Imputer
(or you may also correct existing links)

@thechargedneutron
Copy link
Contributor Author

@qinhanmin2014 Please review this once. You may suggest a different message. Thanks

Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ping @jnothman

@jnothman
Copy link
Member

My time is quite squeezed atm, @qinhanmin2014, so generic pings should probably go elsewhere.


:class:`Imputer` can be used in a Pipeline as a way to build a composite
estimator that supports imputation. See :ref:`sphx_glr_auto_examples_plot_missing_values.py`.
This module is deprecated and has been moved to :ref:`impute`. This would be removed in 0.22.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just rather say "tools for imputing missing values are discussed at ..." so that we don't need to change anything in the future

Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @thechargedneutron

@qinhanmin2014 qinhanmin2014 merged commit 94ed5a8 into scikit-learn:master Mar 13, 2018
@qinhanmin2014
Copy link
Member

My time is quite squeezed atm, @qinhanmin2014, so generic pings should probably go elsewhere.

Thanks @jnothman for your precious time. I ping here because you are heavily involved in relevant PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Imputer references in doc/modules/preprocessing.rst
3 participants