/scikit-learn

[MRG] fix command for make test-coverage #10188

Merged
merged 2 commits into from Nov 23, 2017
+1 −1

Conversation

Reviewers

@lesteve lesteve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@amueller @lesteve
@amueller
Owner

amueller commented Nov 22, 2017

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

amueller added some commits Nov 22, 2017

@amueller
fix command for make test-coverage

Some checks were not successful

2 errored, 1 failing, and 3 successful checks
@codecov
codecov/patch — CI failed.
Details
@codecov
codecov/project — CI failed.
Details
continuous-integration/appveyor/pr — AppVeyor build failed
Details
ci/circleci — Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
lgtm analysis: Python — No alert changes
Details
0d562b6
@amueller
output html report by default

All checks have passed

6 successful checks
ci/circleci — Your tests passed on CircleCI!
Details
@codecov
codecov/patch — Coverage not affected when comparing 816e2eb...2b91782
Details
@codecov
codecov/project — 96.1% remains the same compared to 816e2eb
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
lgtm analysis: Python — No alert changes
Details
2b91782

@amueller amueller requested a review from lesteve Nov 22, 2017

Makefile
@@ -34,7 +34,7 @@ endif
test-coverage:
rm -rf coverage .coverage
- $(PYTEST) sklearn --show-locals -v --with-cov sklearn
+ $(PYTEST) sklearn --showlocals -v --cov=sklearn --cov-report=html:coverage

This comment has been minimized.

Show comment Hide comment
@lesteve

lesteve Nov 23, 2017

Member

Sorry for this, it slips through the cracks it seems ... I checked locally that it was generating the html coverage fine as was the nose equivalent command.

@lesteve

lesteve Nov 23, 2017

Member

Sorry for this, it slips through the cracks it seems ... I checked locally that it was generating the html coverage fine as was the nose equivalent command.

@lesteve

This comment has been minimized.

Show comment Hide comment
@lesteve

lesteve Nov 23, 2017

Member

Merging thanks a lot !

Member

lesteve commented Nov 23, 2017

Merging thanks a lot !

@lesteve lesteve merged commit 26421be into scikit-learn:master Nov 23, 2017
6 checks passed

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 816e2eb...2b91782
Details
codecov/project 96.1% remains the same compared to 816e2eb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
@amueller

This comment has been minimized.

Show comment Hide comment
@amueller

amueller Nov 23, 2017

Owner

Thanks. No worries and thanks for working on all the house-keeping stuff!

Owner

amueller commented Nov 23, 2017

Thanks. No worries and thanks for working on all the house-keeping stuff!

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

@amueller Jeremiah Johnson
[MRG] fix command for make test-coverage (#10188)
db4aa81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment