[3.7] bpo-26901: Fix the Argument Clinic test suite (GH-8879) #9048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Tools/clinic/clinic_test.py: add missing FakeClinic.destination_buffers attribute and pass a file argument to Clinic(). * Rename Tools/clinic/clinic_test.py to Lib/test/test_clinic.py: add temporary Tools/clinic/ to sys.path to import the clinic module. Co-Authored-By: Pablo Galindo <pablogsal@gmail.com> (cherry picked from commit 65fc98e) Co-authored-by: Victor Stinner <vstinner@redhat.com>
|
@serhiy-storchaka, @berkerpeksag, @pablogsal: my PR to add Lib/test/test_clinic.py has been merged to master. Are you ok to also fix Argument Clinic tests in 3.7? I'm not sure about fixing 3.6. |
|
+1 for fixing it in 3.7. I'd skip 3.6 since its bugfix maintenance period will end soon. |
|
+1 for fixing it in 3.7. |
|
@vstinner: Backport status check is done, and it's a success ✅ . |
1 similar comment
|
@vstinner: Backport status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FakeClinic.destination_buffers attribute and pass a file argument
to Clinic().
add temporary Tools/clinic/ to sys.path to import the clinic
module.
Co-Authored-By: Pablo Galindo pablogsal@gmail.com
(cherry picked from commit 65fc98e)
Co-authored-by: Victor Stinner vstinner@redhat.com
https://bugs.python.org/issue26901