Skip to content

[3.6] bpo-25750: fix refcounts in type_getattro() (GH-6118) #9088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2018
Merged

[3.6] bpo-25750: fix refcounts in type_getattro() (GH-6118) #9088

merged 1 commit into from
Sep 7, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 7, 2018 •
edited by bedevere-bot
Loading

When calling tp_descr_get(self, obj, type), make sure that
we own a strong reference to "self".
(cherry picked from commit 8f73548)

Co-authored-by: jdemeyer jdemeyer@cage.ugent.be

https://bugs.python.org/issue25750

@jdemeyer @miss-islington
bpo-25750: fix refcounts in type_getattro() (pythonGH-6118)
b919948 
When calling tp_descr_get(self, obj, type), make sure that
we own a strong reference to "self".
(cherry picked from commit 8f73548)

Co-authored-by: jdemeyer <jdemeyer@cage.ugent.be>
@bedevere-bot bedevere-bot mentioned this pull request Sep 7, 2018
Merged
vstinner
vstinner approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot 🤖!

@vstinner vstinner merged commit 3ee0743 into python:3.6 Sep 7, 2018
@miss-islington miss-islington deleted the backport-8f73548-3.6 branch September 7, 2018 07:57
@miss-islington
Copy link
Contributor Author

@jdemeyer and @vstinner: Backport status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@jdemeyer and @vstinner: Backport status check is done, and it's a failure ❌ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @jdemeyer