bpo-32139: test_strftime does not anymore modify the locale #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Nov 28, 2017
Lib/test/test_strftime.py
Outdated
| try: | ||
| import java | ||
| java.util.Locale.setDefault(java.util.Locale.US) | ||
| except ImportError: | ||
| import locale | ||
| locale.setlocale(locale.LC_TIME, 'C') | ||
| self.saved_locale = setlocale(LC_TIME) |
There was a problem hiding this comment.
I suggest to add here:
self.addCleanup(setlocale, LC_TIME, self.saved_locale)
With that, you avoid tearDown() (which is not called if the test is interrupted by CTRL+c if I recall correctly), and you may even use a local variable instead of an attribute.
There was a problem hiding this comment.
Yes, much better. Thanks for your reviews Victor.
|
Thanks @xdegaye for the PR |
|
Thanks @xdegaye for the PR |
|
GH-4635 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2017
|
GH-4636 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2017
xdegaye
pushed a commit
that referenced
this pull request
Nov 29, 2017
xdegaye
pushed a commit
that referenced
this pull request
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue32139