Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34728: Fix asyncio tests to run under "-Werror" #9661

Merged
merged 1 commit into from Oct 2, 2018
Merged

bpo-34728: Fix asyncio tests to run under "-Werror" #9661

merged 1 commit into from Oct 2, 2018

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Oct 1, 2018 •
edited by bedevere-bot

@1st1 1st1 added the skip news label Oct 1, 2018
@1st1 1st1 self-assigned this Oct 1, 2018
@1st1 1st1 requested review from asvetlov and serhiy-storchaka Oct 1, 2018
@1st1 1st1 requested review from gpshead and rhettinger as code owners Oct 1, 2018
@1st1 1st1 removed request for gpshead and rhettinger Oct 1, 2018
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 2, 2018

Is sleep() with loop tested anymore?

@1st1
Copy link
Member Author

1st1 commented Oct 2, 2018

yes

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 2, 2018

Thank you @1st1 for fixing this.

@1st1 1st1 merged commit 9012a0f into python:master Oct 2, 2018
@1st1 1st1 deleted the fixtests branch Oct 2, 2018
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
@1st1 @yahya-abou-imran
bpo-34728: Fix asyncio tests to run under "-Werror" (pythonGH-9661)
742aaef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov

@serhiy-storchaka serhiy-storchaka

Assignees

@1st1 1st1

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@1st1 @serhiy-storchaka @asvetlov @the-knights-who-say-ni @bedevere-bot