Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgraded to babel 7 #8948
Conversation
vikr01
force-pushed the
vikr01:feature/babel-7
branch
from
fb13c58
to
371f687
Oct 20, 2018
This comment has been minimized.
This comment has been minimized.
|
Vue 3 will use TypeScript. |
This comment has been minimized.
This comment has been minimized.
angelina999990
commented
Oct 23, 2018
|
@Shyam-Chen Why will Vue3.X decide to use TypeScript ? What is the pros and cons? |
yyx990803
merged commit 12e8efc
into
vuejs:dev
Oct 23, 2018
5 checks passed
ci/circleci: install
Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types
Your tests passed on CircleCI!
Details
ci/circleci: test-cover
Your tests passed on CircleCI!
Details
ci/circleci: test-e2e
Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex
Your tests passed on CircleCI!
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
added a commit
to michaelromose/vue
that referenced
this pull request
Nov 30, 2018
vikr01
deleted the
vikr01:feature/babel-7
branch
Jan 2, 2019
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vikr01 commentedOct 15, 2018
•
edited
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchOther information:
Upgrades all
babeldependencies to work withbabelv7.babel-preset-flow-vueis not compatible, so I've recreated it in the.babelrc.jsdirectly.Also changed the
jasmine.jsonfiles tojasmine.jsso thatrequire.resolvecan be used instead of assuming wherenode_modulesare. With things likeplug'n'playcoming to yarn, this is a necessary change.