Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add access to context from serverPrefetch (fix #9447) #9591

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

sh7dm
Copy link

@sh7dm sh7dm commented Feb 28, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
First argument of hook will be context, not vm
The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
    #9447
    Other information:

src/server/render.js Outdated Show resolved Hide resolved
Co-Authored-By: sh7dm <sh7dm@outlook.com>
@sh7dm
Copy link
Author

@sh7dm sh7dm commented Mar 1, 2019

@Justineo I've fixed all problems and added a test for this

@yyx990803 yyx990803 added this to To do in 2.7 Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.7
  
To do
Development

Successfully merging this pull request may close these issues.

None yet

3 participants