Branch: master
-
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
fix(ngRequired): set error correctly when inside ngRepeat and false b…
…y default Previously, in the required validator, we would read the required setting directly from attr.required, where it is set by ngRequired. However, when the control is inside ngRepeat, ngRequired sets it only after a another digest has passed, which means the initial validation run of ngModel does not include the correct required setting. (Before commit 0637a21 this would not have been a problem, as every observed value change triggered a validation). We now use the initially parsed value from ngRequired in the validator. Fixes #16814 Closes #16820
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
-
docs(angular.copy): list object types / features that are not supported
Narretz committedJan 14, 2019 -
docs(angular.copy): add note about destination and source compatibility
Narretz committedJan 11, 2019 -
docs(ngParseExt): note limitations with ngOptions and ngRepeat
Narretz committedJan 11, 2019 -
docs(input[email]): note limitations with IPv6 addresses
Narretz committedJan 11, 2019 Closes #16599
-
docs(ngDisabled): remove restriction to input element
Disabled can be set on many different elements, and might also be used on custom controls, so it's better to remove the restriction completely Closes #16775
-
chore(saucelabs): add `SL_EDGE-1` to browser list
gkalpak committedJan 8, 2019 -
chore(travis): suppress verbose log output and allow error logging
gkalpak committedJan 3, 2019 Based on angular/angular#27657.
-
chore(package): upgrade to latest `karma-sauce-launcher`
gkalpak committedJan 3, 2019 Based on angular/angular#27634.
-
chore(package): upgrade to latest `karma`
gkalpak committedJan 3, 2019 This includes a Karma fix that affects CI flakiness. Based on angular/angular#27735.
-
chore(saucelabs): use 'websocket' for transmission when possible
gkalpak committedJan 8, 2019 -
chore(saucelabs): upgrade to latest SauceConnect
gkalpak committedJan 3, 2019 -
test(ngHref): only run Edge-specific test on relevant Edge versions
gkalpak committedJan 3, 2019
-
docs(guide/Conceptual Overview): use exchangeratesapi.io
As fixer.io introduced an API key and thus a limitation of calls (see https://github.com/fixerAPI/fixer#readme ), change https://api.fixer.io to https://api.exchangeratesapi.io instead, which is "designed and tested to handle thousands of request per second" and has "built in Fixer.io compatibility so you can keep all the libraries you already like and use daily" (from https://api.exchangeratesapi.io ). The idea is from fixerAPI/fixer#107 fixes #16807 Closes #16808
-
docs(ISSUE_TEMPLATE.md): add Opera to browser list
Opera is indirectly supported, although not explicitly tested on (see [here](https://docs.angularjs.org/misc/faq#what-browsers-does-angularjs-work-with-) for more info), so it doesn't hurt adding it to the list of browsers. Closes #16801
-
test(ngAnimate): ensure that `blockTransitions` can be spied upon
Previously the test was assuing that this function was attached to the window, which is not the case in production, nor in the isolated module tests.
-
chore(modules): execute modules unit tests in one karma run
SauceLabs is struggling to keep connecting and disconnecting for each of the modules unit test runs. This commit puts most of the module tests into IIFEs so that they can be run in one go. * ngMock is still tested separately since unlike the other tests it doesn't want to have a pre-built version of ngMock available. * ngAnimate is still tested separately because it does some funny things with globals that were difficult to isolate in the main modules test run.
-
test(ngSanitize): disable a failing Edge test in all versions, includ…
…ing 18 It's been only disabled on Edge 16/17 so far which made it fail in Edge 18. Closes #16786
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
fix(compile): properly handle false value for boolean attrs with jQuery
jQuery skips special boolean attrs treatment in XML nodes for historical reasons and hence AngularJS cannot freely call `.attr(attrName, false) with such attributes. To avoid issues in XHTML, call `removeAttr` in such cases instead. Ref jquery/jquery#4249 Fixes #16778 Closes #16779
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
fix(ngRepeat): fix trackBy function being invoked with incorrect scope
jbedard committedNov 28, 2018