fix(required): correctly validate when required on non-input element … #16836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is surrounded by ngIf Closes angular#16830
gkalpak
reviewed
Feb 21, 2019
|
looks like, all checks are passed but not merged |
3 tasks
…lement is surrounded by ngIf
petebacondarwin
approved these changes
Mar 6, 2019
3 tasks
3 tasks
Kiku-Reise
pushed a commit
to Kiku-Reise/angular.js
that referenced
this issue
Apr 6, 2019
…unded by ngIf Closes angular#16830 Closes angular#16836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…is surrounded by ngIf
Closes #16830
I've also ran this change against the ngMaterial unit tests, the uiBootstrap unit tests, the ionic unit tests, and manually tested with uiSelect.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: