Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upConvert code of conduct to markdown for Github #9776
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Oct 9, 2018
bedevere-bot
added
the
awaiting review
label
Oct 9, 2018
zware
added
skip issue
skip news
labels
Oct 9, 2018
This comment has been minimized.
This comment has been minimized.
|
just one question, why do you convert it to markdown? the document already exists in ReST... |
This comment has been minimized.
This comment has been minimized.
|
Github only accepts code of conducts in markdown: https://help.github.com/articles/adding-a-code-of-conduct-to-your-project/ I think this allows them to show up in various places in the interface like this: and visible to this api https://developer.github.com/v3/codes_of_conduct/ |
This comment has been minimized.
This comment has been minimized.
|
ok, but they don't specify only markdown, they use markdown, that could be .rst but ok |
This comment has been minimized.
This comment has been minimized.
|
No it can't, see here: https://github.com/python/cpython/community |
JulienPalard
merged commit d0bb5d7
into
python:master
Oct 10, 2018
bedevere-bot
removed
the
awaiting review
label
Oct 10, 2018
This comment has been minimized.
This comment has been minimized.
|
Hi @ammaraskar thanks for noticing and fixing! |
added a commit
to yahya-abou-imran/cpython
that referenced
this pull request
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ammaraskar commentedOct 9, 2018
Trivial patch, doesn't need issue or news entry