Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35843: Implement __getitem__ for _NamespacePath #11690

Merged
merged 1 commit into from Mar 8, 2019
Merged

bpo-35843: Implement __getitem__ for _NamespacePath #11690

merged 1 commit into from Mar 8, 2019

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jan 28, 2019 •
edited by brettcannon

No description provided.

eamanu
eamanu approved these changes Jan 29, 2019
View changes
Copy link
Contributor

@eamanu eamanu left a comment

LGTM. I re run the sample used on bpo https://bugs.python.org/issue35843 and have the expected behavior.

@brettcannon brettcannon self-requested a review Feb 14, 2019
@asottile asottile force-pushed the bpo_35843_NamespacePath_Sized branch from 5550ff6 to 0de7e75 Compare Feb 17, 2019
@asottile
Copy link
Contributor Author

@asottile asottile commented Feb 19, 2019

@serhiy-storchaka should be good to review again -- thanks for the tip 👍

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 19, 2019

I can say nothing about whether this idea is good or bad. But technically this PR looks correct.

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 1, 2019

I'm blocking this to see if any other core devs have an opinion on this on the issue tracker, otherwise it LGTM!

@asottile
Copy link
Contributor Author

@asottile asottile commented Mar 7, 2019

@brettcannon given the +1 in the bpo issue I think this is good to go

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 7, 2019

@asottile that's the plan 😄 Just need to find the time to handle the merge (probably tomorrow/Friday).

@brettcannon brettcannon added 🤖 automerge and removed DO-NOT-MERGE labels Mar 8, 2019
@miss-islington miss-islington merged commit ab9b31f into python:master Mar 8, 2019
5 checks passed
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 8, 2019

Thanks, @asottile !

@asottile asottile deleted the bpo_35843_NamespacePath_Sized branch Mar 8, 2019
ma8ma pushed a commit to ma8ma/cpython that referenced this issue Apr 7, 2019
@asottile @ma8ma
bpo-35843: Implement __getitem__ for _NamespacePath (pythonGH-11690)
fdd9dc9
arnolddumas pushed a commit to arnolddumas/cpython that referenced this issue May 3, 2019
@asottile @arnolddumas
bpo-35843: Implement __getitem__ for _NamespacePath (pythonGH-11690)
c3012c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

@brettcannon brettcannon

@eamanu eamanu

Assignees
No one assigned
Labels
CLA signed 🤖 automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@asottile @serhiy-storchaka @brettcannon @eamanu @the-knights-who-say-ni @bedevere-bot @miss-islington