Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(types): allow using functions on the PropTypes (#9692) #9733
+16
−1
Conversation
ktsn
suggested changes
Mar 18, 2019
types/options.d.ts
Outdated
| @@ -144,7 +144,7 @@ export interface RenderContext<Props=DefaultProps> { | |||
| injections: any | |||
| } | |||
|
|
|||
| export type Prop<T> = { (): T } | { new(...args: any[]): T & object } | |||
| export type Prop<T> = { (): T } | { new(...args: any[]): T & object } | {new(...args: string[]): Function;} | |||
This comment has been minimized.
This comment has been minimized.
ktsn
Mar 18, 2019
Member
Please unify the code style with existing one
{ new(...args: string[]): Function }
This comment has been minimized.
This comment has been minimized.
|
/cc @HerringtonDarkholme as you may be interested. |
ktsn
approved these changes
Mar 19, 2019
yyx990803
merged commit df4af4b
into
vuejs:dev
Mar 19, 2019
5 checks passed
ci/circleci: install
Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types
Your tests passed on CircleCI!
Details
ci/circleci: test-cover
Your tests passed on CircleCI!
Details
ci/circleci: test-e2e
Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pikax commentedMar 18, 2019
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: