Fix #9641: v-bind object should be overridable by single bindings #9653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure you are referencing the right issue on this one? |
|
@posva Oops, wrong files. I’ll fix it ASAP. |
Justineo
reviewed
Mar 8, 2019
| @@ -234,7 +234,7 @@ describe('Directive v-bind', () => { | |||
| template: `<test v-bind="test" data-foo="foo" dataBar="bar"/>`, | |||
| components: { | |||
| test: { | |||
| template: '<div :data-foo="dataFoo" :data-bar="dataBar"></div>', | |||
| template: '<div>{{ dataFoo }} {{ dataBar }}</div>', | |||
There was a problem hiding this comment.
The old spec passed because data-foo fell through as an attribute and coincidentally appeared in the final output. Using plain text instead to ensure we got the correct value.
Justineo
reviewed
Mar 8, 2019
| @@ -45,12 +46,13 @@ export function bindObjectProps ( | |||
| : data.attrs || (data.attrs = {}) | |||
| } | |||
| const camelizedKey = camelize(key) | |||
| if (!(key in hash) && !(camelizedKey in hash)) { | |||
| const hyphenatedKey = hyphenate(key) | |||
| if (!(camelizedKey in hash) && !(hyphenatedKey in hash)) { | |||
There was a problem hiding this comment.
We need to ensure both camelCased and kebab-cased keys are checked here.
Kiku-Reise
pushed a commit
to Kiku-Reise/vue
that referenced
this issue
Jun 18, 2019
Lostlover
added a commit
to Lostlover/vue
that referenced
this issue
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: