Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(core): cleanup timeouts for async components (fix #9648) #9649
+78
−2
Conversation
yyx990803
added this to To do
in Maintenance
Mar 13, 2019
ahus1
referenced this pull request
Mar 15, 2019
Closed
Timeouts for async components are not cleared, blocking node on ssr #9648
ahus1
force-pushed the
ahus1:async-timeout-cleanup
branch
from
c460d35
to
0232431
Mar 17, 2019
This comment has been minimized.
This comment has been minimized.
|
Updated PR to include an additional test. The updated test spec now keeps track of all timeouts being set, triggered and cleared. |
yyx990803
merged commit 02d21c2
into
vuejs:dev
Mar 20, 2019
5 checks passed
ci/circleci: install
Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types
Your tests passed on CircleCI!
Details
ci/circleci: test-cover
Your tests passed on CircleCI!
Details
ci/circleci: test-e2e
Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex
Your tests passed on CircleCI!
Details
Maintenance
automation
moved this from To do
to Done
Mar 20, 2019
ahus1
deleted the
ahus1:async-timeout-cleanup
branch
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ahus1 commentedMar 7, 2019
•
edited
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
component-async.spec.js now captures information about all created, triggered and cleared timeouts and verifies after the test that they have been cleared.
Should fix #9648