Skip to content

/angular-cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): update webpack-subresource-integr… #14514

Open
wants to merge 1 commit into
base: master
from
+6 −26

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
PR state: blocked cla: yes
Projects
None yet
Milestone
No milestone
4 participants
@matdryz @alan-agius4 @clydin @googlebot
@matdryz
Copy link

commented May 24, 2019 •
edited

Related to angular/angular-cli#9338

@googlebot googlebot added the cla: yes label May 24, 2019

@matdryz matdryz marked this pull request as ready for review May 24, 2019

@clydin clydin added the blocked label May 24, 2019

@alan-agius4

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented May 25, 2019

The reason why this is blocked is because this version has a peer dependency of html-webpack-plugin. Which is not used in the CLI.
@matdryz

This comment has been minimized.

Sign in to view
Copy link
Author

commented May 27, 2019

Isn't it OK since it is an optional peer dependency?
@clydin

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 28, 2019

Optional peer dependencies functionally don't exist since they are not standardized nor supported by npm.

@alan-agius4 alan-agius4 added PR state: blocked and removed blocked labels Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.