Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-34605: Avoid master/slave terms #9101
bpo-34605: Avoid master/slave terms #9101
Changes from all commits
2cdeced
File filter
Conversations
Jump to
There are no files selected for viewing
ericvsmithSep 7, 2018
Member
I think this reads better as
children
. Althoughpliant
isn't a very common word, and I'm not sure how it's being used here.vstinnerSep 7, 2018
Author
Member
Oh, maybe I should have waited longer before merging this one :-( I'm wasn't 100% sure between "childs" and "children". Sorry, english is not my first language. I created PR #9102 to replace childs with children.
I'm not sure what do you propose for pliant. In case of doubt, I leave it unchanged.
gvanrossumSep 11, 2018
Member
I Googled a bit and it seems "pliant slave" is an old-fashioned way to refer to slaves, and even more demeaning than just "slave" -- I presume it was meant ironically by the original author. We should really replace the entire construct "pliant slaves" with a more neutral term. I don't think "children" is the right term -- I propose "helpers".
vstinnerSep 11, 2018
Author
Member
@gvanrossum, @ericvsmith: Ok, I created #9195
ErroneousFatalitySep 12, 2018
@gvanrossum it's in the same vein as compliant.
serhiy-storchakaSep 14, 2018
Member
Actually both wordings are wrong. This class doesn't represent a pattern object in any sense. I'll open a separate issue for this.
serhiy-storchakaSep 14, 2018
Member
Interesting, "buildslave" was a term used in the Buildbot documentation: http://docs.buildbot.net/0.8.5/manual/cfg-buildslaves.html. In recent versions it was replaced with "worker": http://docs.buildbot.net/1.4.0/manual/cfg-workers.html.