Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.6] bpo-20891: Remove test_capi.test_bpo20891() #5425
Merged
Conversation
My first fix is not enough to make test_bpo20891() reliable. A second fix is needed and it was decided to not backport it, so remove the test instead. For Python 3.6, the workaround is to call PyEval_InitThreads() before spawning the first C thread. Python 3.7 will have both fixes.
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 29, 2018
@vstinner: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedJan 29, 2018
•
edited by bedevere-bot
My first fix is not enough to make test_bpo20891() reliable. A second
fix is needed and it was decided to not backport it, so remove the
test instead.
For Python 3.6, the workaround is to call PyEval_InitThreads() before
spawning the first C thread.
Python 3.7 will have both fixes.
https://bugs.python.org/issue20891