Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39002: Fix simple typo: tranlation -> translation (GH-17517) #17517

Merged
merged 2 commits into from Dec 9, 2019
Merged

bpo-39002: Fix simple typo: tranlation -> translation (GH-17517) #17517

merged 2 commits into from Dec 9, 2019

Conversation

@timgates42
Copy link
Contributor

timgates42 commented Dec 9, 2019 •
edited by bedevere-bot

There is a small typo in Lib/test/test_statistics.py.
Should read translation rather than tranlation.

https://bugs.python.org/issue39002
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Dec 9, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@timgates42

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@timgates42
bpo-39002: Fix simple typo. (GH-17517)
Verified
This commit was signed with a verified signature.
timgates42 Tim Gates
GPG key ID: AE3BE0D53823CF05 Learn about signing commits
Loading status checks…
dad7af3 
There is a small typo in Lib/test/test_statistics.py.
Should read `translation` rather than `tranlation`.
@timgates42 timgates42 force-pushed the timgates42:bugfix/typo_translation branch from 75fb0fb to dad7af3 Dec 9, 2019
@timgates42 timgates42 changed the title Fix simple typo: tranlation -> translation bpo-39002: Fix simple typo: tranlation -> translation (GH-17517) Dec 9, 2019
@timgates42
Add news and acknowledgements
Verified
This commit was signed with a verified signature.
timgates42 Tim Gates
GPG key ID: AE3BE0D53823CF05 Learn about signing commits
Loading status checks…
86dcd39
@corona10
corona10 approved these changes Dec 9, 2019
View changes
Copy link
Member

corona10 left a comment

@timgates42

Thanks for the contribution to cpython project.
Please sign up the CLA please, after that core developers will review your PR :)
Thank you again!
@corona10 corona10 requested a review from rhettinger Dec 9, 2019
@rhettinger
rhettinger approved these changes Dec 9, 2019
View changes
@rhettinger rhettinger merged commit c18b805 into python:master Dec 9, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191209.7 succeeded
Details
bedevere/issue-number Issue number 39002 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 9, 2019

Thanks @timgates42 for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 9, 2019
@timgates42 @miss-islington
bpo-39002: Fix simple typo: tranlation -> translation (pythonGH-17517)
d930070 
(cherry picked from commit c18b805)

Co-authored-by: Tim Gates <tim.gates@iress.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 9, 2019

GH-17538 is a backport of this pull request to the 3.8 branch.
@timgates42

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

timgates42 commented Dec 9, 2019

Thanks @corona10 - not to worry I did sign it yesterday and the check-python-cla site is now reporting that I'm all signed up - Thanks all!
rhettinger added a commit that referenced this pull request Dec 10, 2019
@miss-islington @timgates42 @rhettinger
bpo-39002: Fix simple typo: tranlation -> translation (GH-17517) (GH-…
Loading status checks…
859767d 
…17538)

(cherry picked from commit c18b805)

Co-authored-by: Tim Gates <tim.gates@iress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger

@corona10 corona10

Assignees
No one assigned
Labels
CLA not signed type-tests
Projects
None yet
Milestone
No milestone
6 participants
@timgates42 @the-knights-who-say-ni @miss-islington @bedevere-bot @rhettinger @corona10
You can’t perform that action at this time.