Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-24925: _find_lineno now finds doctest __test__ string line numbers #17553
Conversation
If the doctest code is in a test string, _find_lineno now find the error, by looking for a line in the docstring that is unique in the source file.
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 10, 2019
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This comment has been minimized.
This comment has been minimized.
|
I am having a bit of trouble getting my news file to work here. |
This comment has been minimized.
This comment has been minimized.
|
Yes, it is now actually tested and it works! |
Just after I claimed it was fixed, I made a typo. Anyway.
jneb commentedDec 10, 2019
•
edited by bedevere-bot
If the doctest code is in a test string, _find_lineno now find the error, by looking for a line in the docstring that is unique in the source file.
https://bugs.python.org/issue24925