Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39033: Fix NameError in zipimport during hash validation #17588
+286
−269
Conversation
tirkarthi
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as
code owners
|
Nice catch from the issuer :) Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tirkarthi commentedDec 13, 2019
•
edited by bedevere-bot
Fix
NameErrorinzipimportduring hash validation and add a regression test.https://bugs.python.org/issue39033