Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glob uses fnmatch.filter instead of fnmatch since 2001 #10102

Merged
merged 2 commits into from Nov 7, 2018

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Oct 25, 2018

glob uses fnmatch.filter since b5d4d2a

Copy link
Member

@tirkarthi tirkarthi left a comment

LGTM. Thanks for the PR :)

@matrixise
Copy link
Member

matrixise commented Nov 4, 2018

LGTM. @JulienPalard I think you could check this PR. I have compiled and checked the result for me, it's fine.

Doc/library/fnmatch.rst Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka merged commit ae31e3f into python:master Nov 7, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Nov 7, 2018

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2018
(cherry picked from commit ae31e3f)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 7, 2018

GH-10392 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2018
(cherry picked from commit ae31e3f)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 7, 2018

GH-10393 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2018
(cherry picked from commit ae31e3f)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 7, 2018

GH-10394 is a backport of this pull request to the 2.7 branch.

@andresdelfino andresdelfino deleted the fnmatch-glob-filter branch Nov 7, 2018
miss-islington added a commit that referenced this pull request Nov 7, 2018
(cherry picked from commit ae31e3f)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request Nov 7, 2018
(cherry picked from commit ae31e3f)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request Nov 7, 2018
(cherry picked from commit ae31e3f)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants