Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct a couple of unbalanced parenthesis #10779

Merged
merged 12 commits into from Dec 5, 2018
Merged

Correct a couple of unbalanced parenthesis #10779

merged 12 commits into from Dec 5, 2018

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Nov 28, 2018

No description provided.

@andresdelfino andresdelfino requested a review from a team as a code owner Nov 28, 2018
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 28, 2018
This was referenced Nov 28, 2018
Closed
Closed
serhiy-storchaka
serhiy-storchaka reviewed Nov 29, 2018
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

LGTM, but this needs a review of some native speaker. It may be better to reword documentation in some cases to avoid nested parentheses.

Doc/library/email.message.rst Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka requested a review from vadmium Nov 29, 2018
serhiy-storchaka and others added 2 commits Nov 29, 2018
@andresdelfino
Copy link
Contributor Author

andresdelfino commented Nov 29, 2018 •
edited

I changed all occurrences of nested parentheses.

serhiy-storchaka
serhiy-storchaka reviewed Dec 5, 2018
View changes
Doc/library/exceptions.rst Outdated Show resolved Hide resolved
Doc/library/exceptions.rst Outdated Show resolved Hide resolved
Doc/using/windows.rst Show resolved Hide resolved
Doc/library/sysconfig.rst Outdated Show resolved Hide resolved
serhiy-storchaka and others added 4 commits Dec 5, 2018
@serhiy-storchaka @andresdelfino
Update Doc/library/exceptions.rst
c05daa4 
Co-Authored-By: andresdelfino <adelfino@gmail.com>
@serhiy-storchaka @andresdelfino
Update Doc/library/exceptions.rst
603ccac 
Co-Authored-By: andresdelfino <adelfino@gmail.com>
@andresdelfino
Address comment from Serhiy
c7b63da
@andresdelfino
Add missing period at the end of paragraph
c48529e
@serhiy-storchaka serhiy-storchaka merged commit 55f41e4 into python:master Dec 5, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2018

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2018
@andresdelfino @miss-islington
Correct a couple of unbalanced parenthesis. (pythonGH-10779)
195dd08 
(cherry picked from commit 55f41e4)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2018

GH-10940 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2018

Sorry, @andresdelfino and @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 55f41e45b4318cbe19209f5144641344d0049fb8 3.6

@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2018

Sorry, @andresdelfino and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 55f41e45b4318cbe19209f5144641344d0049fb8 2.7

@andresdelfino andresdelfino deleted the missing-parens branch Dec 5, 2018
miss-islington added a commit that referenced this pull request Dec 5, 2018
@miss-islington @andresdelfino
Correct a couple of unbalanced parenthesis. (GH-10779)
349d991 
(cherry picked from commit 55f41e4)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2018

GH-10945 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka pushed a commit that referenced this pull request Dec 5, 2018
@andresdelfino @serhiy-storchaka
[3.6] Correct a couple of unbalanced parenthesis. (GH-10779). (GH-10945)
62af9e6 
(cherry picked from commit 55f41e4)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@terryjreedy
Copy link
Member

terryjreedy commented Dec 5, 2018

Thank you Andres and Serhiy. I post-reviewed this and it looks great, and fixes some text bugs that can be more obnoxious than simple typos.

andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 5, 2018
@andresdelfino
[2.7] Correct a couple of unbalanced parenthesis. (pythonGH-10779).
5fe36f4 
(cherry picked from commit 55f41e4)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2018

GH-10963 is a backport of this pull request to the 2.7 branch.

@serhiy-storchaka serhiy-storchaka removed their assignment Dec 6, 2018
serhiy-storchaka pushed a commit that referenced this pull request Dec 6, 2018
@andresdelfino @serhiy-storchaka
[2.7] Correct a couple of unbalanced parenthesis. (GH-10779). (GH-10963)
46aa472 
(cherry picked from commit 55f41e4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

@python/email-team email-team

@vadmium vadmium

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andresdelfino @miss-islington @bedevere-bot @terryjreedy @serhiy-storchaka @the-knights-who-say-ni