Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Fix Default Argument Values of xml.dom.minidom.Document.toprettyxml #10814

Merged
merged 1 commit into from Nov 30, 2018
Merged

[Docs] Fix Default Argument Values of xml.dom.minidom.Document.toprettyxml #10814

merged 1 commit into from Nov 30, 2018

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Nov 30, 2018

The document is inconsistent with

cpython/Lib/xml/dom/minidom.py

Line 49 in 55e4980

def toprettyxml(self, indent="\t", newl="\n", encoding=None):

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 30, 2018
@e-kwsm e-kwsm changed the title [Docs] Fix signature of xml.dom.minidom.Document.toprettyxml [Docs] Fix Default Argument Values of xml.dom.minidom.Document.toprettyxml Nov 30, 2018
@serhiy-storchaka serhiy-storchaka merged commit b7c2182 into python:master Nov 30, 2018
@miss-islington
Copy link
Contributor

Thanks @e-kwsm for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @e-kwsm and @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b7c2182604d5796b5af4c837991aa0b8c8a2d41f 3.7

@miss-islington
Copy link
Contributor

Sorry, @e-kwsm and @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b7c2182604d5796b5af4c837991aa0b8c8a2d41f 3.6

@miss-islington
Copy link
Contributor

Sorry, @e-kwsm and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b7c2182604d5796b5af4c837991aa0b8c8a2d41f 2.7

e-kwsm added a commit to e-kwsm/cpython that referenced this pull request Nov 30, 2018
@e-kwsm
Fix signature of xml.dom.minidom.Document.toprettyxml(). (pythonGH-10814
d3c0749 
)

(cherry picked from commit b7c2182)
e-kwsm added a commit to e-kwsm/cpython that referenced this pull request Nov 30, 2018
@e-kwsm
[3.7] Fix signature of xml.dom.minidom.Document.toprettyxml(). (pytho…
ecf6654 
…nGH-10814).

(cherry picked from commit b7c2182)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
e-kwsm added a commit to e-kwsm/cpython that referenced this pull request Nov 30, 2018
@e-kwsm
Fix signature of xml.dom.minidom.Document.toprettyxml(). (pythonGH-10814
ddba5ee 
)

(cherry picked from commit b7c2182)
e-kwsm added a commit to e-kwsm/cpython that referenced this pull request Nov 30, 2018
@e-kwsm
[3.6] Fix signature of xml.dom.minidom.Document.toprettyxml(). (pytho…
946e8f7 
…nGH-10814).

(cherry picked from commit b7c2182)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
@e-kwsm e-kwsm deleted the fix-docs-Node.toprettyxml branch November 30, 2018 16:23
e-kwsm added a commit to e-kwsm/cpython that referenced this pull request Nov 30, 2018
@e-kwsm
[2.7] Fix signature of xml.dom.minidom.Document.toprettyxml(). (pytho…
eae198f 
…nGH-10814).

(cherry picked from commit b7c2182)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
@bedevere-bot
Copy link

GH-10827 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka pushed a commit that referenced this pull request Dec 1, 2018
@e-kwsm @serhiy-storchaka
[2.7] Fix signature of xml.dom.minidom.Document.toprettyxml(). (GH-10814
dfd4a1d 
). (GH-10827)

(cherry picked from commit b7c2182)
@bedevere-bot
Copy link

GH-10824 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka pushed a commit that referenced this pull request Dec 1, 2018
@e-kwsm @serhiy-storchaka
[3.7] Fix signature of xml.dom.minidom.Document.toprettyxml(). (GH-10814
7da9755 
). (GH-10824)

(cherry picked from commit b7c2182)
@bedevere-bot
Copy link

GH-10825 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka pushed a commit that referenced this pull request Dec 1, 2018
@e-kwsm @serhiy-storchaka
[3.6] Fix signature of xml.dom.minidom.Document.toprettyxml(). (GH-10814
1e28daf 
). (GH-10825)

(cherry picked from commit b7c2182)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 5, 2018
@e-kwsm e-kwsm mentioned this pull request Dec 5, 2018
Merged
@miss-islington miss-islington mentioned this pull request Dec 5, 2018
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2018
@e-kwsm @miss-islington
Fix typo in xml.dom.minidom documentation (pythonGH-10956)
636caf0 
Escape the \t and \n.
Follow up from python#10814.
(cherry picked from commit 2d8f976)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
miss-islington pushed a commit that referenced this pull request Dec 5, 2018
@e-kwsm @miss-islington
Fix typo in xml.dom.minidom documentation (GH-10956)
2d8f976 
Escape the \t and \n.
Follow up from #10814.
@Mariatta Mariatta mentioned this pull request Dec 5, 2018
Merged
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Dec 5, 2018
@e-kwsm @Mariatta
[3.7] Fix typo in xml.dom.minidom documentation (pythonGH-10956)
ff8bcb2 
Escape the \t and \n.
Follow up from python#10814..
(cherry picked from commit 2d8f976)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Dec 5, 2018
@e-kwsm @Mariatta
[3.6] Fix typo in xml.dom.minidom documentation (pythonGH-10956)
ff2d25e 
Escape the \t and \n.
Follow up from python#10814..
(cherry picked from commit 2d8f976)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
@Mariatta Mariatta mentioned this pull request Dec 5, 2018
Merged
miss-islington added a commit that referenced this pull request Dec 5, 2018
@miss-islington @e-kwsm
Fix typo in xml.dom.minidom documentation (GH-10956)
40ef5b7 
Escape the \t and \n.
Follow up from #10814.
(cherry picked from commit 2d8f976)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
miss-islington pushed a commit that referenced this pull request Dec 5, 2018
@Mariatta @e-kwsm @miss-islington
[3.6] Fix typo in xml.dom.minidom documentation (GH-10956) (GH-10962)
f7fe18a 
Escape the \t and \n.
Follow up from #10814..
(cherry picked from commit 2d8f976)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
miss-islington pushed a commit that referenced this pull request Dec 6, 2018
@Mariatta @e-kwsm @miss-islington
[3.7] Fix typo in xml.dom.minidom documentation (GH-10956) (GH-10961)
c28317e 
Escape the \t and \n.
Follow up from #10814..
(cherry picked from commit 2d8f976)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@e-kwsm @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni