-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-37640: Fix telnetlib crash in Python3 while receiving un-printable characters from server #14877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Please change the PR title to be of the format |
@tirkarthi: This code doesn't need a version test. The stdlib always only runs on the version it's shipped with. Agreed about needing tests and NEWS. |
Hi everyone, this issue should be fixing because a lot of CTF tools are based on it if it upgrades to python 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add tests and a Misc/NEWS entry (using blurb).
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution but
- Sign the CLA
- Remove the test and simplify the code.
Thank you
@peternguyen93, just another reminder to sign the CLA and address the code review. Without that, we'll have to close your PR. Thanks! |
I'm going to close this pull request as the author has not signed the CLA after more than one request to do so. Once the CLA is signed, this can be reopened. Thank you. |
https://bugs.python.org/issue37640