Skip to content

bpo-37640: Fix telnetlib crash in Python3 while receiving un-printable characters from server #14877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

peternguyen93
Copy link

@peternguyen93 peternguyen93 commented Jul 21, 2019

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@tirkarthi
Copy link
Member

Please change the PR title to be of the format bpo-NNNN: Description of the fix where NNNN is the issue number to make sure the PR is linked to the issue. This PR would require tests and a NEWS entry. Given that the fix is applied on master branch I am not sure if the code to detect to be above python 3.6 is needed.

@ericvsmith
Copy link
Member

@tirkarthi: This code doesn't need a version test. The stdlib always only runs on the version it's shipped with. Agreed about needing tests and NEWS.

@peternguyen93 peternguyen93 changed the title fix-issue-37640 bpo-37640: Fix telnetlib crash in Python3 while receiving un-printable characters from server Jul 23, 2019
@peternguyen93
Copy link
Author

Hi everyone, this issue should be fixing because a lot of CTF tools are based on it if it upgrades to python 3

Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add tests and a Misc/NEWS entry (using blurb).

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution but

  1. Sign the CLA
  2. Remove the test and simplify the code.

Thank you

@csabella
Copy link
Contributor

@peternguyen93, just another reminder to sign the CLA and address the code review. Without that, we'll have to close your PR. Thanks!

@csabella
Copy link
Contributor

csabella commented Jan 5, 2020

I'm going to close this pull request as the author has not signed the CLA after more than one request to do so. Once the CLA is signed, this can be reopened. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants