bpo-38669: Add check for the type of target #17034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
reviewed
Nov 3, 2019
|
Please add the issue number in the required format so that the PR is linked to the issue. I guess this needs a NEWS entry. |
elenaoat
changed the title
elenaoat
force-pushed
the
bpo-38669
branch
2 times, most recently
from
76ed816
to
382d0bc
Compare
ammaraskar
reviewed
Nov 4, 2019
ammaraskar
reviewed
Nov 5, 2019
brandtbucher
requested changes
Nov 5, 2019
Thanks for the patch @elenaoat! I've got a couple of formatting suggestions, but otherwise I like what you've done here:
Misc/NEWS.d/next/Tests/2019-11-04-02-54-16.bpo-38669.pazXZ8.rst
Outdated
Show resolved
Hide resolved
Also add a test.
Remove the unnecessary else too.
Also improve formatting and enrich news.
ammaraskar
approved these changes
Nov 6, 2019
ZackerySpytz
reviewed
Nov 8, 2019
No need to use f-string.
tirkarthi
approved these changes
Nov 10, 2019
|
@cjw296 Given the approvals it would be helpful to have your review of this PR. Thanks. |
cjw296
approved these changes
Dec 8, 2019
Looks good to me! Honestly, I'd think of this as a bug and so would be happy to see it backported.
|
I'm having trouble backporting to |
|
@Mariatta - any ideas on the socket error above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue38669