Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39004: increment large sendfile() test timeout #17552
Merged
Conversation
Lib/test/test_largefile.py
Outdated
| @@ -168,7 +168,7 @@ def test_it(self): | |||
| @unittest.skipIf(not hasattr(os, 'sendfile'), 'sendfile not supported') | |||
| class TestSocketSendfile(LargeFileTest, unittest.TestCase): | |||
| open = staticmethod(io.open) | |||
| timeout = 3 | |||
| timeout = 20 | |||
This comment has been minimized.
This comment has been minimized.
vstinner
Dec 10, 2019
Member
I suggest to use support.SHORT_TIMEOUT, or event support.LONG_TIMEOUT. See the new timeout constants:
https://docs.python.org/dev/library/test.html#test.support.LOOPBACK_TIMEOUT
This comment has been minimized.
This comment has been minimized.
|
LGTM. FYI I have a local branch to replace dozens of hardcoded constants with the new test.support constants. But I didn't find time to create a proper PR yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
giampaolo commentedDec 10, 2019
•
edited by bedevere-bot
https://bugs.python.org/issue39004
https://bugs.python.org/issue39004