New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39009: Fix typo in test__locale #17544

Merged

pablogsal merged 6 commits into python:master from timgates42:bugfix/typo_thousands

Dec 9, 2019

Contributor

timgates42 commented Dec 9, 2019 •

edited by miss-islington

There is a small typo in Lib/test/test__locale.py.
Should read thousands rather than thousauds.

https://bugs.python.org/issue39009

Automerge-Triggered-By: @pablogsal


        bpo-39002: Fix simple typo. (GH-17517)

dad7af3

There is a small typo in Lib/test/test_statistics.py.
Should read `translation` rather than `tranlation`.

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting review label

timgates42 changed the title ~~bpo-39009: Fix simple typo: thousauds -> thousands~~ bpo-39009: Fix simple typo: thousauds -> thousands (GH-17544)


        bpo-39009: Fix simple typo. (GH-17544)

172e10f

There is a small typo in Lib/test/test__locale.py.
Should read `thousands` rather than `thousauds`.

timgates42 force-pushed the timgates42:bugfix/typo_thousands branch from 4bcaec6 to 172e10f

pablogsal requested changes

Misc/NEWS.d/next/Documentation/2019-12-09-10-12-00.bpo-39002.AfgvfO.rst Outdated Show resolved Hide resolved

bedevere-bot removed the awaiting review label

bedevere-bot commented Dec 9, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot added the awaiting changes label

pablogsal added the skip news label

timgates42 added 2 commits


        Delete 2019-12-09-10-12-00.bpo-39002.AfgvfO.rst

b55ea9e


        Merge branch 'master' of ssh://github.com/python/cpython into bugfix/…

3a40168

…typo_thousands

pablogsal approved these changes

Member

pablogsal left a comment

LGTM

Thanks @timgates42 for the contribution! 🚀


        Merge branch 'bugfix/typo_thousands' of ssh://github.com/timgates42/c…

c2d2e3f

…python into bugfix/typo_thousands

bedevere-bot added awaiting merge and removed awaiting changes labels


        restore accidental delete from other PR

pablogsal changed the title ~~bpo-39009: Fix simple typo: thousauds -> thousands (GH-17544)~~ bpo-39009: Fix typo in test__locale

pablogsal self-assigned this

pablogsal added the 🤖 automerge label

miss-islington commented Dec 9, 2019

@timgates42: Status check is done, and it's a failure ❌ .

1 similar comment

miss-islington commented Dec 9, 2019

@timgates42: Status check is done, and it's a failure ❌ .

pablogsal removed the 🤖 automerge label

Contributor Author

timgates42 commented Dec 9, 2019

I have made the requested changes; please review again

bedevere-bot added awaiting change review and removed awaiting merge labels

bedevere-bot commented Dec 9, 2019

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

bedevere-bot requested a review from pablogsal

pablogsal merged commit 2ad7651 into python:master

4 checks passed

4 checks passed

Azure Pipelines PR #20191209.44 succeeded

Details

bedevere/issue-number Issue number 39009 found

Details

bedevere/news "skip news" label found

continuous-integration/travis-ci/pr The Travis CI build passed

Details

bedevere-bot removed the awaiting change review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.