Skip to content

[3.6] bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934). #11001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2018
Merged

[3.6] bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934). #11001

merged 1 commit into from
Dec 6, 2018
+11 −5

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 6, 2018 •
edited by bedevere-bot
Loading

(cherry picked from commit 42b1d61)

https://bugs.python.org/issue33023

@serhiy-storchaka
[3.6] bpo-33023: Fix NotImplemented to NotImplementedError. (pythonGH…
10695c9 
…-10934).

(cherry picked from commit 42b1d61)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Dec 6, 2018
Merged
@bedevere-bot bedevere-bot added skip news type-bug An unexpected behavior, bug, or error awaiting merge labels Dec 6, 2018
@serhiy-storchaka serhiy-storchaka merged commit 7a2cf1e into python:3.6 Dec 6, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the backport-42b1d61-3.6 branch December 6, 2018 21:00
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7a2cf1e7d3bf300e98c702589d405734f4a8fcf8 2.7

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 6, 2018
@serhiy-storchaka
[2.7] bpo-33023: Fix NotImplemented to NotImplementedError. (pythonGH…
f820f55 
…-10934). (pythonGH-11001)

(cherry picked from commit 42b1d61).
(cherry picked from commit 7a2cf1e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Dec 7, 2018
@serhiy-storchaka
[2.7] bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934)…
324e179 
…. (GH-11001) (GH-11008)

(cherry picked from commit 42b1d61)
(cherry picked from commit 7a2cf1e)
Julsy pushed a commit to Julsy/cpython that referenced this pull request May 4, 2019
Fixed issue python#11001, updated coockie docs
2d7e9b0
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @the-knights-who-say-ni @bedevere-bot