[2.7] bpo-36235: Fix CFLAGS in distutils customize_compiler() (GH-12236) #12349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CFLAGS in customize_compiler() of distutils.sysconfig: when the CFLAGS environment variable is defined, don't override CFLAGS variable with the OPT variable anymore. Initial patch written by David Malcolm. Co-Authored-By: David Malcolm <dmalcolm@redhat.com> (cherry picked from commit 86082c2)
esc
added a commit
to esc/numba
that referenced
this pull request
Oct 30, 2019
At some point in October 2019 the Python 2.7 Builds on MacOSX started
failing with the following error:
```
/Users/runner/miniconda3/envs/travisci/include/python2.7/Python.h:33:10: fatal error: 'stdio.h' file not found
^~~~~~~~~
1 error generated.
```
While it isn't clear where the root cause of this issue lies --- either
with the Anaconda based c-compilers or with the Microsoft build image
--- this patch
It is to be suspected that the following backport may be involved:
python/cpython#12349
This also means that future releases of Python may actually suffer from
the same issue, so we will have to keep an eye on these.
Hopfully, this patch will no longer be required when Python 2.7 is EOL
in 2020.
esc
added a commit
to esc/numba
that referenced
this pull request
Oct 30, 2019
At some point in October 2019 the Python 2.7 Builds on MacOSX started
failing with the following error:
```
/Users/runner/miniconda3/envs/travisci/include/python2.7/Python.h:33:10: fatal error: 'stdio.h' file not found
^~~~~~~~~
1 error generated.
```
While it isn't clear where the root cause of this issue lies --- either
with the Anaconda based c-compilers or with the Microsoft build image
--- this patch
It is to be suspected that the following backport may be involved:
python/cpython#12349
This also means that future releases of Python may actually suffer from
the same issue, so we will have to keep an eye on these.
Hopfully, this patch will no longer be required when Python 2.7 is EOL
in 2020.
esc
added a commit
to esc/numba
that referenced
this pull request
Oct 30, 2019
At some point in October 2019 the Python 2.7 Builds on MacOSX started
failing with the following error:
```
/Users/runner/miniconda3/envs/travisci/include/python2.7/Python.h:33:10: fatal error: 'stdio.h' file not found
^~~~~~~~~
1 error generated.
```
While it isn't clear where the root cause of this issue lies --- either
with the Anaconda based c-compilers or with the Microsoft build image
--- this patch
It is to be suspected that the following backport may be involved:
python/cpython#12349
This also means that future releases of Python may actually suffer from
the same issue, so we will have to keep an eye on these.
Hopfully, this patch will no longer be required when Python 2.7 is EOL
in 2020.
jua74470
pushed a commit
to jua74470/python2.7
that referenced
this pull request
Nov 14, 2024
Upstreamed patches: - 157: python/cpython#12235 - 168: python/cpython#12349 Rebased patches: - 189: updated bundles setuptools/pip versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CFLAGS in customize_compiler() of distutils.sysconfig: when the
CFLAGS environment variable is defined, don't override CFLAGS variable with
the OPT variable anymore.
Initial patch written by David Malcolm.
Co-Authored-By: David Malcolm dmalcolm@redhat.com
(cherry picked from commit 86082c2)
https://bugs.python.org/issue36235