Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-36307: Upgrade Travis CI to Xenial and rm obsolete sudo:false #12356
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Mar 15, 2019
bedevere-bot
added
the
awaiting review
label
Mar 15, 2019
This comment has been minimized.
This comment has been minimized.
Okay, looks like everything's green with the same number of skips; aside from the allowed failures, which fail in the same way as on other PRs with the previous infrastructure. As a minor, 2-line meta-change to the CI infrastructure, I didn't think this merited a NEWS entry, but I'm happy to add one if desired. |
Mariatta
added
skip issue
skip news
labels
Mar 15, 2019
Mariatta
approved these changes
Mar 15, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
Mar 15, 2019
Mariatta
added
needs backport to 2.7
needs backport to 3.7
labels
Mar 15, 2019
This comment has been minimized.
This comment has been minimized.
There were Openssl compatibility issues in the past and xenial used to be less stable. I would request waiting for people working closely with buildbots to review this before merging and also backporting since this changes base image of one of primary CI. See also some discussion in https://bugs.python.org/issue34009 . |
This comment has been minimized.
This comment has been minimized.
Thanks @tirkarthi .
To note, at least according to the issue you linked, these issues were reported with Trusty, whereas the OpenSSL version distributed with Xenial is compatible. Therefore, we could switch back to the distro-provided version, though it makes sense to keep it building its own version to demonstrate how to do so, exercise that functionality and ensure compatibility with the latest OpenSSL. While were at it, should we also bump the version up to the latest 1.1.1b, which is the current LTS branch (with 1.0.2 EoL in Dec. 2019 and 1.1.0 EoL in a few months, in September)?
We will indeed want to confirm this with the relevant parties, as this is not a trivial change, but I do note just based on the thread, the one individual who commented about Xenial not working reliably later took it back, saying it only required extra configuration (which is no longer the case). However, there may be other issues of which I'm aware (we ourselves haven't had any since spyder-ide/spyder#8802 , but obviously we're not exactly CPython). |
This comment has been minimized.
This comment has been minimized.
Thanks for the details. I was curious and just used search where the thread came up. I too would be happy to have it clarified along with backporting by someone else for the upgrade. |
This comment has been minimized.
This comment has been minimized.
I searched for related terms as well, but for whatever reason didn't find that particular thread. Thanks for the heads up. |
methane
merged commit 74ae50e
into
python:master
Mar 18, 2019
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Mar 18, 2019
Thanks @CAM-Gerlach for the PR, and @methane for merging it |
bedevere-bot
removed
the
awaiting merge
label
Mar 18, 2019
added a commit
that referenced
this pull request
Mar 18, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Mar 18, 2019
GH-12404 is a backport of this pull request to the 2.7 branch. |
bedevere-bot
removed
the
needs backport to 2.7
label
Mar 18, 2019
added a commit
that referenced
this pull request
Mar 18, 2019
bedevere-bot
removed
the
needs backport to 3.7
label
Mar 18, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Mar 18, 2019
GH-12405 is a backport of this pull request to the 3.7 branch. |
CAM-Gerlach commentedMar 15, 2019
•
edited
Currently, the .travis.yml config file still has a
sudo: false
key, which previously triggered the Container-based environment on Travis. However, that was removed in December 2018, and so the key is now obsolete. Furthermore, the builds are still running in the Trusty (Ubuntu 14.04) environment, which will be at the end of its 5-year development lifecycle in April 2019 (next month). Therefore,sudo: false
should be removed, and the presumably, if possible, the distribution should be upgraded to the moderndist: xenial
(Ubuntu 16.04).https://bugs.python.org/issue36307