Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() #12687

Merged
merged 2 commits into from Apr 22, 2019
Merged

bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() #12687

merged 2 commits into from Apr 22, 2019

Conversation

@ZackerySpytz
Copy link
Contributor

ZackerySpytz commented Apr 4, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue9194
@ZackerySpytz
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ()
Loading status checks…
b6def9c
@ZackerySpytz ZackerySpytz requested a review from python/windows-team as a code owner Apr 4, 2019
@ZackerySpytz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ZackerySpytz commented Apr 4, 2019

It would be nice to have a unit test for this, but I don't think that's feasable. It seems that the unit test would have to write corrupted data.
@berkerpeksag
berkerpeksag reviewed Apr 22, 2019
View changes
Misc/NEWS.d/next/Windows/2019-04-04-08-59-44.bpo-9194.DzakhD.rst Outdated Show resolved Hide resolved
@ZackerySpytz
Remove the news entry.
Loading status checks…
ba22b12
@zooba zooba merged commit 56ed864 into python:master Apr 22, 2019
5 checks passed
5 checks passed
Azure Pipelines PR #20190422.5 succeeded
Details
bedevere/issue-number Issue number 9194 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Apr 22, 2019

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Apr 22, 2019

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Apr 22, 2019

GH-12909 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Apr 22, 2019
@ZackerySpytz @miss-islington
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (pytho…
03dbc44 
…nGH-12687)

(cherry picked from commit 56ed864)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Apr 22, 2019

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Apr 22, 2019

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Apr 22, 2019
@ZackerySpytz @miss-islington
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (pytho…
c026c8b 
…nGH-12687)

(cherry picked from commit 56ed864)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Apr 22, 2019

GH-12910 is a backport of this pull request to the 3.6 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Apr 22, 2019

Sorry, @ZackerySpytz and @zooba, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 56ed86490cb8221c874d432461d77702437f63e5 2.7
miss-islington added a commit that referenced this pull request Apr 22, 2019
@miss-islington @ZackerySpytz
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (GH-12687
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7038dee 
)

(cherry picked from commit 56ed864)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
ZackerySpytz added a commit to ZackerySpytz/cpython that referenced this pull request Apr 22, 2019
@ZackerySpytz
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (pytho…
3ab55ac 
…nGH-12687)

(cherry picked from commit 56ed864)
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Apr 22, 2019

GH-12916 is a backport of this pull request to the 2.7 branch.
miss-islington added a commit that referenced this pull request Apr 22, 2019
@ZackerySpytz @miss-islington
[2.7] bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (G…
Loading status checks…
84efbae 
…H-12687) (GH-12916)

(cherry picked from commit 56ed864)



https://bugs.python.org/issue9194
ned-deily added a commit that referenced this pull request May 2, 2019
@miss-islington @ZackerySpytz @ned-deily
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (GH-12687
Loading status checks…
dadc347 
) (GH-12910)

(cherry picked from commit 56ed864)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
arnolddumas added a commit to arnolddumas/cpython that referenced this pull request May 3, 2019
@ZackerySpytz @arnolddumas
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (pytho…
5193147 
…nGH-12687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag

@python/windows-team windows-team

Assignees

@zooba zooba

Labels
CLA signed OS-windows needs backport to 3.7 skip news
Projects
None yet
Milestone
No milestone
6 participants
@ZackerySpytz @miss-islington @bedevere-bot @berkerpeksag @zooba @the-knights-who-say-ni
You can’t perform that action at this time.