Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32758: Warn that compile() can crash when compiling to an AST object #6043

Merged
merged 1 commit into from Mar 9, 2018
Merged

bpo-32758: Warn that compile() can crash when compiling to an AST object #6043

merged 1 commit into from Mar 9, 2018

Conversation

@brettcannon
Copy link
Member

brettcannon commented Mar 9, 2018 •
edited by bedevere-bot

https://bugs.python.org/issue32758
@brettcannon
Warn that compile() can crash when compiling to an AST object
Loading status checks…
4d72f3f
@brettcannon brettcannon self-assigned this Mar 9, 2018
@brettcannon brettcannon merged commit f7a6ff6 into python:master Mar 9, 2018
4 checks passed
4 checks passed
bedevere/issue-number Issue number 32758 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Mar 9, 2018

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
@brettcannon brettcannon deleted the brettcannon:compile-warning branch Mar 9, 2018
miss-islington added a commit to miss-islington/cpython that referenced this pull request Mar 9, 2018
@brettcannon @miss-islington
Warn that compile() can crash when compiling to an AST object (python…
ada3035 
…GH-6043)

(cherry picked from commit f7a6ff6)

Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Mar 9, 2018

GH-6045 is a backport of this pull request to the 3.7 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Mar 9, 2018

Sorry, @brettcannon, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f7a6ff6fcab32a53f262ba3f8a072c27afc330d7 2.7
miss-islington added a commit to miss-islington/cpython that referenced this pull request Mar 9, 2018
@brettcannon @miss-islington
Warn that compile() can crash when compiling to an AST object (python…
5fdaca6 
…GH-6043)

(cherry picked from commit f7a6ff6)

Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Mar 9, 2018

GH-6046 is a backport of this pull request to the 3.6 branch.
brettcannon added a commit that referenced this pull request Mar 9, 2018
@miss-islington @brettcannon
Warn that compile() can crash when compiling to an AST object (GH-6043)…
Loading status checks…
fc5e095 
… (GH-6045)

(cherry picked from commit f7a6ff6)

Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
brettcannon added a commit that referenced this pull request Mar 9, 2018
@miss-islington @brettcannon
Warn that compile() can crash when compiling to an AST object (GH-6043)…
Loading status checks…
19b42fe 
… (GH-6046)

(cherry picked from commit f7a6ff6)

Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
jo2y added a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
@brettcannon @jo2y
Warn that compile() can crash when compiling to an AST object (python…
c2a063b 
…GH-6043)
@serhiy-storchaka

This comment has been minimized.

Sign in to view
Copy link
Member

serhiy-storchaka commented Apr 22, 2018

Do you mind to create a backport to 2.7 @brettcannon?
yahya-abou-imran added a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
@brettcannon @yahya-abou-imran
Warn that compile() can crash when compiling to an AST object (python…
b54179c 
…GH-6043)
@naglis naglis mentioned this pull request Nov 9, 2018
Open
@naglis naglis mentioned this pull request Nov 21, 2018
Open
AWhetter added a commit to AWhetter/cpython that referenced this pull request Oct 3, 2019
@brettcannon @AWhetter
bpo-32758: Warn that compile() can crash when compiling to an AST obj…
d7da475 
…ect (pythonGH-6043)

(cherry picked from commit f7a6ff6)

Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Oct 3, 2019

GH-16566 is a backport of this pull request to the 2.7 branch.
serhiy-storchaka added a commit that referenced this pull request Oct 18, 2019
@AWhetter @brettcannon @serhiy-storchaka
bpo-32758: Warn that compile() can crash when compiling to an AST obj…
8eb27cc 
…ect (GH-6043) (GH-16566)

(cherry picked from commit f7a6ff6)

Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brettcannon brettcannon

Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@brettcannon @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni
You can’t perform that action at this time.