Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38823: Clean up refleaks in _contextvars initialization. #17198

Merged
merged 1 commit into from Nov 16, 2019

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Nov 16, 2019

@brandtbucher brandtbucher requested a review from 1st1 as a code owner Nov 16, 2019
@brandtbucher brandtbucher added skip news type-bug An unexpected behavior, bug, or error labels Nov 16, 2019
@asvetlov asvetlov added 🤖 automerge PR will be merged once it's been approved and all CI passed needs backport to 3.7 needs backport to 3.8 labels Nov 16, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2019

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 143a97f into python:master Nov 16, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2019

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2019

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@asvetlov
Copy link
Contributor

asvetlov commented Nov 16, 2019

Thanks again!

@bedevere-bot
Copy link

bedevere-bot commented Nov 16, 2019

GH-17199 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2019
…H-17198)

https://bugs.python.org/issue38823
(cherry picked from commit 143a97f)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2019

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 16, 2019

GH-17200 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Nov 17, 2019
https://bugs.python.org/issue38823
(cherry picked from commit 143a97f)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
miss-islington added a commit that referenced this pull request Nov 17, 2019
https://bugs.python.org/issue38823
(cherry picked from commit 143a97f)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants